Skip to content

fix: use full path in Directory.SetCurrentDirectory #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2023
Merged

fix: use full path in Directory.SetCurrentDirectory #1028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51c1212
The current directory should always be a rooted path, even if the dir…
vbreuss Aug 22, 2023
6ec44d8
Merge branch 'main' into topic/vb/setcurrentdirectory-should-set-abso…
fgreinacher Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDirectory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ public override void SetCreationTimeUtc(string path, DateTime creationTimeUtc)
/// <inheritdoc />
public override void SetCurrentDirectory(string path)
{
currentDirectory = path;
currentDirectory = mockFileDataAccessor.Path.GetFullPath(path);
}

/// <inheritdoc />
Expand Down
11 changes: 11 additions & 0 deletions tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1661,6 +1661,17 @@ public void MockDirectory_SetCurrentDirectory_ShouldChangeCurrentDirectory()
Assert.AreEqual(directory, fileSystem.Directory.GetCurrentDirectory());
}

[Test]
public void MockDirectory_SetCurrentDirectory_WithRelativePath_ShouldUseFullPath()
{
var fileSystem = new MockFileSystem();
fileSystem.Directory.SetCurrentDirectory(".");

var result = fileSystem.Directory.GetCurrentDirectory();

Assert.IsTrue(fileSystem.Path.IsPathRooted(result));
}

[Test]
public void MockDirectory_GetParent_ShouldThrowArgumentNullExceptionIfPathIsNull()
{
Expand Down