Skip to content

feat: add ReparsePoint attribute when creating a symbolic link #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2023
Merged

feat: add ReparsePoint attribute when creating a symbolic link #1024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9bbd27
Set ReparsePoint for directories
vbtig Aug 20, 2023
56570c1
Set ReparsePoint for files
vbtig Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/TestableIO.System.IO.Abstractions.TestingHelpers/MockDirectory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,9 @@ public override IFileSystemInfo CreateSymbolicLink(string path, string pathToTar
mockFileDataAccessor.AddDirectory(path);
mockFileDataAccessor.GetFile(path).LinkTarget = pathToTarget;

return new MockDirectoryInfo(mockFileDataAccessor, path);
var directoryInfo = new MockDirectoryInfo(mockFileDataAccessor, path);
directoryInfo.Attributes |= FileAttributes.ReparsePoint;
return directoryInfo;
}
#endif

Expand Down
4 changes: 3 additions & 1 deletion src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,9 @@ public override IFileSystemInfo CreateSymbolicLink(string path, string pathToTar
destFileData.LinkTarget = pathToTarget;
mockFileDataAccessor.AddFile(path, destFileData);

return new MockFileInfo(mockFileDataAccessor, path);
var mockFileInfo = new MockFileInfo(mockFileDataAccessor, path);
mockFileInfo.Attributes |= FileAttributes.ReparsePoint;
return mockFileInfo;
}
#endif
/// <inheritdoc />
Expand Down
14 changes: 14 additions & 0 deletions tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectorySymlinkTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,20 @@ public void MockDirectory_CreateSymbolicLink_ShouldFailIfTargetDoesNotExist()
Assert.That(ex.Message.Contains(pathToTarget));
}

[Test]
public void MockDirectory_CreateSymbolicLink_ShouldSetReparsePointAttribute()
{
var path = "foo";
var pathToTarget = "bar";
var fileSystem = new MockFileSystem();
fileSystem.Directory.CreateDirectory(pathToTarget);

fileSystem.Directory.CreateSymbolicLink(path, pathToTarget);

var attributes = fileSystem.DirectoryInfo.New(path).Attributes;
Assert.IsTrue(attributes.HasFlag(FileAttributes.ReparsePoint));
}

[Test]
public void MockDirectory_ResolveLinkTarget_ShouldReturnPathOfTargetLink()
{
Expand Down
14 changes: 14 additions & 0 deletions tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileSymlinkTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,20 @@ public void MockFile_CreateSymbolicLink_ShouldFailIfPathDirectoryDoesNotExist()
Assert.That(ex.Message.Contains(path));
}

[Test]
public void MockFile_CreateSymbolicLink_ShouldSetReparsePointAttribute()
{
var path = "foo.txt";
var pathToTarget = "bar.txt";
var fileSystem = new MockFileSystem();
fileSystem.File.WriteAllText(pathToTarget, "some content");

fileSystem.File.CreateSymbolicLink(path, pathToTarget);

var attributes = fileSystem.FileInfo.New(path).Attributes;
Assert.IsTrue(attributes.HasFlag(FileAttributes.ReparsePoint));
}

[Test]
public void MockFile_ResolveLinkTarget_ShouldReturnPathOfTargetLink()
{
Expand Down