-
-
Notifications
You must be signed in to change notification settings - Fork 493
Add support for channel tabs #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 48 commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
ed4559d
fix: support richGridRenderer on channel page
Theta-Dev 8b4b431
feat: add tab support to channel extractor
Theta-Dev 18e3758
feat: add channel tabs
Theta-Dev 78bbbd4
fix: handle unsupported content, hide tab bar with < 2 tabs
Theta-Dev 9a9fae9
feat: prettier channel info page
Theta-Dev 667ab2a
feat: add album tab
Theta-Dev 57865e2
feat: add visitor data config option
Theta-Dev aed685e
feat: add tab support for Peertube
Theta-Dev 53e772c
feat: add tab support for Soundcloud
Theta-Dev e6907ca
fix: Peertube playlist urls
Theta-Dev 04c7e46
Merge branch 'dev' of github.com:TeamNewPipe/NewPipeExtractor into ch…
Theta-Dev edaaaac
fix: checkstyle errors
Theta-Dev 1253773
fix: store YouTube visitor data for channel tabs
Theta-Dev 94523ad
feat: add Bandcamp album tab
Theta-Dev a592c96
test: add channel tab extractor tests
Theta-Dev f3b064a
fix: change playlist tab parameter to include YTM albums
Theta-Dev 0a458d8
fix: NPE when extracting YT stream items without duration
Theta-Dev 856584f
fix: channel shorts duration parsing
Theta-Dev 7ec6a44
fix: channel short upload date parsing
Theta-Dev f71fdac
refactor: API changes
Theta-Dev 73c182f
Merge branch 'dev' of github.com:TeamNewPipe/NewPipeExtractor into ch…
Theta-Dev abf0473
fix: support new PlaylistInfoItem interface
Theta-Dev 8a3545c
fix: rename channel tab LIVE to LIVESTREAMS
Theta-Dev 7dba12b
fix: link handler urls for tabs
Theta-Dev f6d8652
fix: update mock data
Theta-Dev 2245de1
fix: make getTab nonnull
Theta-Dev 8d3bc2b
fix: YoutubeParsingHelper formatting
Theta-Dev f7e3b71
Merge branch 'dev' into channel-tabs
Theta-Dev ffd02a4
fix: shorts continuation
Theta-Dev c156c40
Merge branch 'dev' of github.com:TeamNewPipe/NewPipeExtractor into ch…
Theta-Dev d2c2aca
fix: tests failing to compile
Theta-Dev 8446e20
test: update channel tab mocks
Theta-Dev 9cebcf7
Merge branch 'dev' of github.com:TeamNewPipe/NewPipeExtractor into ch…
Theta-Dev 5b63a3e
tests: update mocks, remove special cases for a/b test
Theta-Dev 76052de
fix: YT shorts view count parsing
Theta-Dev 8ecee87
fix: channel extractor tests, docs
Theta-Dev 8cd6439
fix: YT shorts view count parsing (2)
Theta-Dev c6ee2f3
fix: add checkIfChannelResponseIsValid method
Theta-Dev 97d7ee5
Merge branch 'dev' of github.com:Theta-Dev/NewPipeExtractor into chan…
Theta-Dev f306db0
refactor: move YT channel utils to YouTubeChannelHelper
Theta-Dev e57d43f
Merge branch 'dev' of github.com:TeamNewPipe/NewPipeExtractor into ch…
Theta-Dev 750f158
add comment to clarify channel tab param
Theta-Dev e278a2d
refactor: use streams instead of for loops
Theta-Dev c3651be
Channels are now an Info
Stypox 12ca6a2
fix tests
Theta-Dev 294ffab
Add documentation for ReadyChannelTabLLH
Stypox bad1238
Fix PeerTube channel tabs content filters
Stypox 6e0ffaf
fix: Peertube channel tab extractor fetching global feed
Theta-Dev 308fc43
fix: make ChannelTabExtractorBuilder serializable
Theta-Dev 6b627f8
feat: fetch YT Shorts using internal playlist
Theta-Dev 2ad496f
refactor: merge YoutubeChannelTabExtractor and YoutubeChannelVideosTa…
Theta-Dev 0c5fdac
fix: remove overridden getId function in PeertubeAccountExtractor
Theta-Dev 6a38811
[Bandcamp] Use same url for tracks and albums channel tabs
Stypox d47d0f9
fix: add Bandcamp URL suffixes
Theta-Dev 417b797
Merge branch 'dev' of github.com:TeamNewPipe/NewPipeExtractor into ch…
Theta-Dev 0e28f2b
tests: add tests for channel tab urls
Theta-Dev 0583515
tests: separate channel/tab tests for Peertube, Bandcamp, Soundcloud
Theta-Dev a3f6a7e
tests: add @override to YT channel/tab tests
Theta-Dev d868746
Merge branch 'dev' of github.com:TeamNewPipe/NewPipeExtractor into ch…
Theta-Dev 2adc2ca
fix: use assertTabs method, rename channelTab mock folder
Theta-Dev e8fab3b
fix: add #1050 fix to channel tab name extraction
Theta-Dev b1f8905
docs: add docs to ChannelTabInfo
Theta-Dev 66d8038
refactor: remove getTab() method from ChannelTabExtractor
Theta-Dev 6c5a225
fix: improve shorts duration parser
Theta-Dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
extractor/src/main/java/org/schabi/newpipe/extractor/channel/ChannelTabExtractor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package org.schabi.newpipe.extractor.channel; | ||
|
||
import org.schabi.newpipe.extractor.InfoItem; | ||
import org.schabi.newpipe.extractor.ListExtractor; | ||
import org.schabi.newpipe.extractor.StreamingService; | ||
import org.schabi.newpipe.extractor.exceptions.ParsingException; | ||
import org.schabi.newpipe.extractor.linkhandler.ListLinkHandler; | ||
|
||
import javax.annotation.Nonnull; | ||
|
||
public abstract class ChannelTabExtractor extends ListExtractor<InfoItem> { | ||
|
||
public ChannelTabExtractor(final StreamingService service, | ||
final ListLinkHandler linkHandler) { | ||
super(service, linkHandler); | ||
} | ||
|
||
@Nonnull | ||
public String getTab() { | ||
Theta-Dev marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Theta-Dev marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
return getLinkHandler().getContentFilters().get(0); | ||
} | ||
|
||
@Nonnull | ||
@Override | ||
public String getName() throws ParsingException { | ||
return getTab(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.