Fix extraction of some properties in ItagItems for YouTube livestreams and post-live streams and remove completely SoundCloud HLS workaround #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elds for ItagItems of live streams and post live streams These values were only set before for video streams. A fallback for the audio channels count has been added, in order to prevent exceptions when generating DASH manifests of audio streams: the fallback value is 2, because most audio streams on YouTube have 2 audio channels.
SoundCloud is currently removing this workaround completely, so there is no need to keep it, because it impacts the loading time (a HLS playlist was downloaded and parsed).
AudricV
added
bug
Stypox
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Thank you! Simple fix, and sorry for the mistake in b3c620f#diff-e07bd9a3dfb657e0ac68c2847533825c0c25d9cc8486c9a5a0dab1d413d54d42R1361
| || itagType == ItagItem.ItagType.VIDEO_ONLY) { | ||
| } | ||
|
|
||
| if (itagType == ItagItem.ItagType.VIDEO || itagType == ItagItem.ItagType.VIDEO_ONLY) { |
There was a problem hiding this comment.
Ooops, I didn't notice the if above was referring to streamType instead of itagItem, that's why I accidentally added an else
3 tasks
litetex
added a commit
to litetex/NewPipeExtractor
that referenced
this pull request
Jun 18, 2022
litetex
added a commit
to litetex/NewPipeExtractor
that referenced
this pull request
Jun 19, 2022
litetex
added a commit
to litetex/NewPipeExtractor
that referenced
this pull request
Jun 19, 2022
litetex
added a commit
to litetex/NewPipeExtractor
that referenced
this pull request
Jun 19, 2022
litetex
added a commit
to litetex/NewPipeExtractor
that referenced
this pull request
Jun 24, 2022
litetex
added a commit
to litetex/NewPipeExtractor
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue, when adding
ItagItem's properties on livestreams and post livestreams, where thefps,audioSampleRateandaudioChannelsvalues were not set for these stream types (and so only set for video streams, thanks to aelseintroduced by @Stypox in c8a77da).This caused exceptions when creating DASH manifests of audio streams (because a valid number of audio channels is required in the
AudioChannelConfigurationelement of DASH manifests). To prevent it again, if this value is unknown, a fallback to2has been added (because most YouTube audio streams have 2 channels).This PR also removes completely the SoundCloud HLS workaround which is being removed progressively by SoundCloud for MP3 streams too. Unfortunately, it means for UMG tracks (which have now a faster loading time because no HLS manifest is now fetched) that no progressive stream will be available for download in NewPipe.