Extract related bandcamp items #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fynngodau
added
enhancement
TobiGr
reviewed
Apr 13, 2021
.../java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampStreamExtractor.java
Show resolved
Hide resolved
TobiGr
approved these changes
Apr 13, 2021
|
Am I missing something? In the RC I get "No videos" on any stream I try, including the one in the screenshot. |
|
@opusforlife2 This change is not included in the RC for 0.21.2. I opened this PR six days ago, the RC PR TeamNewPipe/NewPipe#6053 was posted 8 days ago. |
|
Updated the RC |
|
Yeah, I tested RC2 and it works. 👍 |
|
On a related note, maybe merged PRs shouldn't be added to the Release Issue and PR until the RC with those merged PRs is out? Merged PRs can still be added to the draft release notes on the Releases page to help keep track. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts recommended playlists as recommended playlists in NewPipeExtractor. Fixes #593.