Skip to content

Add body field to Page and use it #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 6, 2021
Merged

Add body field to Page and use it #599

merged 3 commits into from
Apr 6, 2021

Conversation

@XiangRongLin
Copy link
Collaborator

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Is based on #598 so that i can see if it runs in CI

@XiangRongLin XiangRongLin added the youtube service, https://www.youtube.com/ label Apr 2, 2021
AudricV
AudricV reviewed Apr 2, 2021
View reviewed changes
Copy link
Member

@AudricV AudricV left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also switch the API domain from https://www.youtube.com/youtubei/v1 to https://youtubei.googleapis.com/youtubei/v1 for the POST requests? It can reduce the consent cookies redirects and responses are the same.

@XiangRongLin XiangRongLin marked this pull request as ready for review April 4, 2021 09:42
AudricV
AudricV approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a nit below.

@XiangRongLin
Copy link
Collaborator Author

Test failure is from soundcloud and not from youtube

@XiangRongLin XiangRongLin merged commit 90afd61 into TeamNewPipe:dev Apr 6, 2021
@XiangRongLin XiangRongLin mentioned this pull request Apr 9, 2021
Closed
This was referenced Apr 12, 2021
Closed
Merged
@XiangRongLin XiangRongLin deleted the post_body branch July 10, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TobiGr TobiGr TobiGr left review comments

@AudricV AudricV AudricV approved these changes

Assignees

No one assigned

Labels

youtube service, https://www.youtube.com/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XiangRongLin @TobiGr @AudricV