Pass on gradle JVM system property to test JVM #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
requested changes
Jan 15, 2021
XiangRongLin
force-pushed
the
test_jvm_property
branch
from
fd44e8c to
a6cfe11
Compare
|
@Stypox done |
Stypox
approved these changes
Jan 15, 2021
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like i misunderstood how gradle system properties work and somehow even missed it.
Now the system property is actually accessable from inside the tests, meaning CI jobs with a different downloader passed in via CLI, will actually use those downloaders