Fix name of media.ccc.de service #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
approved these changes
Dec 2, 2020
TobiGr
added a commit
to TeamNewPipe/NewPipe
that referenced
this pull request
Dec 23, 2020
Caused by changing service name in TeamNewPipe/NewPipeExtractor#472
5 tasks
TobiGr
added a commit
to TeamNewPipe/NewPipe
that referenced
this pull request
Dec 23, 2020
Caused by changing service name in TeamNewPipe/NewPipeExtractor#472
TobiGr
added a commit
to TeamNewPipe/NewPipe
that referenced
this pull request
Dec 23, 2020
Caused by changing service name in TeamNewPipe/NewPipeExtractor#472
spvkgn
pushed a commit
to spvkgn/NewPipe
that referenced
this pull request
Dec 26, 2020
Caused by changing service name in TeamNewPipe/NewPipeExtractor#472
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Well, arguably, the last point makes little sense, unless we also change the class names.)
This fixes the name of the service for https://media.ccc.de. Nobody other than NewPipe ever used the term "MediaCCC". I've seen some software around the site use "CCC-TV", but CCC themselves seem just to use the domain.
This is the least invasive method, as it merely changes the service's name string, which is then rendered in the app.
I am open to changing all the class names, but it'll be hard to find a new naming scheme.
MediaCccDemight work, though.