Remove any reference to decrypt and improve error message #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheAssassin @B0pol is this ok? |
TheAssassin
requested changes
Oct 28, 2020
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Show resolved
Hide resolved
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Show resolved
Hide resolved
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Show resolved
Hide resolved
|
@TheAssassin @B0pol I modified the error message to "Could not load deobfuscation code from YouTube video embed", so that "embed" is mentioned. Also, I ran all stream extractor tests on my machine and they all work fine, meaning that changing "encryption" to "deobfuscation" (used for each and every video) has no effect as expected |
TheAssassin
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Looks good to me. Let's wait for @B0pol to have a look, too.
B0pol
approved these changes
Oct 28, 2020
This was referenced Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This definitely removes any reference to "decrypt": it was still used to build the custom JS to send to the interpreter, therefore it can be changed if changed everywhere. On my machine tests pass.