Bandcamp support

[fynngodau]

• I carefully read the contribution guidelines and agree to them.
• I did test the API against NewPipe.
• Icons need to be added to NewPipe for Featured and Radio and for Bandcamp itself. Bandcamp support NewPipe#3741

---

Fixes #138
Fixes TeamNewPipe/NewPipe#1284

I had to add the org.json library because the website contains some JSON that has unquoted keys.

• Search
• Multiple search pages
• Search suggestions
• Streams
  Descriptions are suboptimal because their newlines get eaten and then lyrics are really difficult to read Not anymore for some reason.
• Channels
  Actually implemented, but depends on Playlist in channels #227
• Playlists work
  Playlists with a lot of streams take ages to load, because for every playlist info item, a separate request needs to be made to find out the URL of its cover. I'll see whether I can add a workaround just for playlists with more than a number (e.g. 10) of streams Workaround ba967f1 only loads cover art of each track individually for playlists <= 10 streams
• Kiosks
  • Featured kiosk
    Currently only loads nine items currently can't load further "pages"; can contain preorder albums whose cover is not always displayed correctly and which shows errors but works once opened
  • Bandcamp weekly (Radio) kiosk
    Clicking uploader's (primary host's) name causes the crash reporter to open as it is a link to a fan page
• Fan pages
  Are extra work because they look different and don't really provide a lot of value I think
• Comments
  (fanthanks / writings)
• Unit tests
  But I'm not sure of their quality

[fynngodau]

Is the CI failing my fault? I believe it is not; one of my tests was failing, but I fixed it with 46e1f39.

[Stypox]

@fynngodau you can see whether it's your fault or not by clicking on Details to the right of continuous-integration/travis-ci/pr. As you can see there, the problem is not yours, but is caused by SoundCloud that at the moment is buggy ;-)

[XiangRongLin]

From a quick look it looks ok for me. Except for the license line, the things I commented on can be addresses in seperate PRs.

I did not look at the tests

Also is there anywhere global state? From my cursory glace it does not look like it.

[XiangRongLin]

why is this empty

[XiangRongLin]

Can the reason for why its empty be added here

[TobiGr]

it is not empty anymore. i moved some of the code which was falsely placed in getInitialPage()

[XiangRongLin]

Reviewing something this big again is really time consuming. If the points from my previous review were addressed, then its good to go.

The small stuff can be handled in seperate PR, which are then way easiert to review. Like adding the reason for empty methods and replace the remaining occurences of bandcamp.com

---

On a side note: Since all of the most recent commits were made by you @TobiGr, are you going to continue maintaining this service or is @fynngodau going to help too?

[XiangRongLin]

Can the reason for why its empty be added here

[fynngodau]

On a side note: Since all of the most recent commits were made by you @TobiGr, are you going to continue maintaining this service or is @fynngodau going to help too?

Hi, I'm still interested in maintaining this, however after having maintained this PR without it actually being used for a year or so, I'm glad that I don't have to do these final steps myself. Then I can open some other, smaller PRs with fixes as needed or follow-up features.

In case you're wondering why I was not in the IRC channel, I was probably kicked for inactivity, or I forgot to join with my new matrix account.