Skip to content

Update user agent to Firefox ESR 140 for test downloader #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025
Merged

Update user agent to Firefox ESR 140 for test downloader #1348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9dbcba
Update USER_AGENT to Firefox ESR 140
TobiGr Jul 27, 2025
0378fde
Fix checkstyle
TobiGr Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extractor/src/test/java/org/schabi/newpipe/downloader/DownloaderTestImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public final class DownloaderTestImpl extends Downloader {
* Should be the latest Firefox ESR version.
*/
private static final String USER_AGENT =
"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:128.0) Gecko/20100101 Firefox/128.0";
"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:140.0) Gecko/20100101 Firefox/140.0";
private static DownloaderTestImpl instance;
private final RateLimitedClientWrapper clientWrapper;

Expand Down
2 changes: 1 addition & 1 deletion ...or/src/test/java/org/schabi/newpipe/downloader/ratelimiting/RateLimitedClientWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public Response executeRequestWithLimit(final Request request) throws IOExceptio
}

final Response response = client.newCall(request).execute();
if(response.code() != 429) { // 429 = Too many requests
if (response.code() != 429) { // 429 = Too many requests
return response;
}
cause = new IllegalStateException("HTTP 429 - Too many requests");
Expand Down
6 changes: 3 additions & 3 deletions extractor/src/test/java/org/schabi/newpipe/downloader/ratelimiting/limiter/RateLimiter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public static RateLimiter create(
final TimeUnit unit,
final double coldFactor
) {
if(warmupPeriod < 0) {
if (warmupPeriod < 0) {
throw new IllegalArgumentException(
"warmupPeriod must not be negative: " + warmupPeriod);
}
Expand Down Expand Up @@ -248,7 +248,7 @@ private Object mutex() {
* @throws IllegalArgumentException if {@code permitsPerSecond} is negative or zero
*/
public final void setRate(final double permitsPerSecond) {
if(permitsPerSecond <= 0.0) {
if (permitsPerSecond <= 0.0) {
throw new IllegalArgumentException("rate must be positive");
}
synchronized (mutex()) {
Expand Down Expand Up @@ -489,7 +489,7 @@ protected void sleepMicrosUninterruptibly(final long micros) {
}

private static void checkPermits(final int permits) {
if(permits <= 0.0) {
if (permits <= 0.0) {
throw new IllegalArgumentException(
"Requested permits (" + permits + ") must be positive");
}
Expand Down