[YouTube] Support LOCKUP_CONTENT_TYPE_PODCAST #1338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
LOCKUP_CONTENT_TYPE_PODCASTlockup view model by reusing the lockup playlist item extractor. The JSON is basically the same asLOCKUP_CONTENT_TYPE_PLAYLIST, I even tried doing a diff and their structure is identical.JSON
{ "1": { "lockupViewModel": { "contentImage": { "collectionThumbnailViewModel": { "primaryThumbnail": { "thumbnailViewModel": { "image": { "sources": [ { "url": "https://i.ytimg.com/pl_c/PLO1kG5YTufOZJSMc9QddoVZhjN1l8egdL/studio_square_thumbnail.jpg?sqp=CMCU3sMG-oaymwEICPABEPABSFqi85f_AwYI6oG9vQY=&rs=AOn4CLApEpZwgLEPcWmMr6_cs6IR5PkXTg", "width": 240, "height": 240 }, { "url": "https://i.ytimg.com/pl_c/PLO1kG5YTufOZJSMc9QddoVZhjN1l8egdL/studio_square_thumbnail.jpg?sqp=CNKI3sMG-oaymwEICOADEOADSFqi85f_AwYI6oG9vQY=&rs=AOn4CLDpdAz93ci5onCCltBh4kNZqk0w6g", "width": 480, "height": 480 }, { "url": "https://i.ytimg.com/pl_c/PLO1kG5YTufOZJSMc9QddoVZhjN1l8egdL/studio_square_thumbnail.jpg?sqp=CJis3sMG-oaymwEICNAFENAFSFqi85f_AwYI6oG9vQY=&rs=AOn4CLD9RhKytxnOMuRCIlimhkAT-cvo6A", "width": 720, "height": 720 } ] }, "overlays": [ { "thumbnailOverlayBadgeViewModel": { "thumbnailBadges": [ { "thumbnailBadgeViewModel": { "icon": { "sources": [ { "clientResource": { "imageName": "BROADCAST" } } ] }, "text": "23 episodes", "badgeStyle": "THUMBNAIL_OVERLAY_BADGE_STYLE_DEFAULT", "backgroundColor": { "lightTheme": 2763059, "darkTheme": 2763059 } } } ], "position": "THUMBNAIL_OVERLAY_BADGE_POSITION_BOTTOM_END" } }, { "thumbnailHoverOverlayViewModel": { "icon": { "sources": [ { "clientResource": { "imageName": "PLAY_ALL" } } ] }, "text": { "content": "Play all", "styleRuns": [ { "startIndex": 0, "length": 8 } ] }, "style": "THUMBNAIL_HOVER_OVERLAY_STYLE_COVER" } } ], "backgroundColor": { "lightTheme": 2763058, "darkTheme": 2763058 } } }, "stackColor": { "lightTheme": 8354713, "darkTheme": 8486299 } } }, "metadata": { "lockupMetadataViewModel": { "title": { "content": "Кампанія 2 \"Ехо Аркани\" [Записи ігор]" }, "metadata": { "contentMetadataViewModel": { "metadataRows": [ { "metadataParts": [ { "text": { "content": "View full podcast", "commandRuns": [ { "startIndex": 0, "length": 17, "onTap": { "innertubeCommand": { "clickTrackingParams": "REDACTED", "commandMetadata": { "webCommandMetadata": { "url": "/playlist?list=PLO1kG5YTufOZJSMc9QddoVZhjN1l8egdL", "webPageType": "WEB_PAGE_TYPE_PLAYLIST", "rootVe": 5754, "apiUrl": "/youtubei/v1/browse" } }, "browseEndpoint": { "browseId": "VLPLO1kG5YTufOZJSMc9QddoVZhjN1l8egdL" } } } } ], "styleRuns": [ { "startIndex": 0, "length": 17, "weightLabel": "FONT_WEIGHT_MEDIUM" } ] } } ] } ], "delimiter": " • " } } } }, "contentId": "PLO1kG5YTufOZJSMc9QddoVZhjN1l8egdL", "contentType": "LOCKUP_CONTENT_TYPE_PODCAST", "rendererContext": { "loggingContext": { "loggingDirectives": { "trackingParams": "REDACTED", "visibility": { "types": "12" } } }, "commandContext": { "onTap": { "innertubeCommand": { "clickTrackingParams": "REDACTED", "commandMetadata": { "webCommandMetadata": { "url": "/watch?v=CKX4TlQS-Ug&list=PLO1kG5YTufOZJSMc9QddoVZhjN1l8egdL&pp=0gcJCV8EOCosWNin", "webPageType": "WEB_PAGE_TYPE_WATCH", "rootVe": 3832 } }, "watchEndpoint": { "videoId": "CKX4TlQS-Ug", "playlistId": "PLO1kG5YTufOZJSMc9QddoVZhjN1l8egdL", "params": "OAI%3D", "playerParams": "REDACTED", "loggingContext": { "vssLoggingContext": { "serializedContextData": "REDACTED" } }, "watchEndpointSupportedOnesieConfig": { "html5PlaybackOnesieConfig": { "commonConfig": { "url": "REDACTED" } } } } } } } } } } }While I was at it, I also made
LOCKUP_CONTENT_TYPE_VIDEO(#1320) work in other places in the app (not just recommended videos), just in case they'll start using it more in the future.Here is a testing APK: app-debug.zip
Fixes TeamNewPipe/NewPipe#12321