[Soundcloud] Add support for AAC 160k unprotected stream and update Creative Commons stream test #1317
+19
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stream isn't returned in DRM-protected tracks, of course.
The track which was used has been deleted, so replace it with another track from the account. The AAC 160k unprotected stream isn't present on this track, only recent ones seem to have it.
AudricV
added
soundcloud
AudricV
changed the title
TobiGr
reviewed
Jul 7, 2025
...a/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudStreamExtractor.java
Show resolved
Hide resolved
TobiGr
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces Creative Commons' test in
SoundcloudStreamExtractorTestand adds support for an AAC HLS stream with an average bitrate of 160kbps, which isn't returned in DRM-protected tracks, of course.