[YouTube] Fix crash on SABR-only player responses, do not use WEB client for stream URLs anymore #1297
+28
−166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
added
bug
Stypox
approved these changes
May 7, 2025
Stypox
approved these changes
May 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
NullPointerExceptions when an adapative format has no stream URL available, which is the case for SABR-only YouTube player responses, rolled out for the WEB client (almost?) completely. This caused the extractor to crash, as no null handling for URLs was made.TVHTML5client usage for streaming has been also removed for now, as signatures extraction of HTML5 clients is currently broken (WEB_EMBEDDED_PLAYERfallback for age-restricted video is still done but won't work).Stream mocks need to be updated.
Fixes TeamNewPipe/NewPipe#12126, fixes TeamNewPipe/NewPipe#12134.