[YouTube] Add support for automatic dubbed and secondary audio tracks #1237
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
added
enhancement
TobiGr
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for (i.e. distinguish) automatic dubbed audio tracks made by YouTube and secondary audio tracks.
Automatic dubbed tracks are generated by YouTube for creators and an example can be found on this video: https://www.youtube.com/watch?v=snZ9w5xc_ic. They are now treated like normal dubbed tracks with this PR.
Secondary audio tracks have now their own track type. In the DASH specification, a specific role value for these tracks doesn't seem to exist, so I used the default value of an audio track type in DASH manifests generated by the extractor,
alternate. Here is a video with this track type: https://www.youtube.com/watch?v=UPrkC1LdlLY