Skip to content

Improved image-minimizer #7884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2022
Merged

Improved image-minimizer #7884

merged 2 commits into from
Feb 17, 2022

Conversation

@litetex
Copy link
Member

@litetex litetex commented Feb 15, 2022

What is it?

  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Improved image-minimizer:

  • Don't minimize images that are too wide -> they will get stretched otherwise
  • Don't try to modify the issue/comment when nothing changed
  • Fixed typo

Before/After Screenshots/Screen Record

Due diligence

@litetex
Improved image-minimizer
c08a4e8 
* Don't minimize images that are too wide -> they will get stretched otherwise
* Don't try to modify the issue/comment when nothing changed
* Fixed typo
@litetex litetex added bug Issue is related to a bug meta Related to the project but not strictly to code labels Feb 15, 2022
triallax
triallax suggested changes Feb 16, 2022
View reviewed changes
@litetex
Fixed typo
7225199 
It was late when I typed this 😆
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@litetex litetex merged commit 2814ae6 into TeamNewPipe:dev Feb 17, 2022
@litetex litetex deleted the improve-image-minimizer branch February 17, 2022 18:33
@Stypox Stypox mentioned this pull request Feb 23, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@triallax triallax triallax approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Issue is related to a bug meta Related to the project but not strictly to code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@litetex @triallax