Skip to content

Conversation

@akamayu-ouo
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Add traditional Chinese translation of README.md

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV added localisation / translation Everything that has to do with translations or Weblate meta Related to the project but not strictly to code labels Jan 4, 2022
@triallax
Copy link
Contributor

triallax commented Jan 6, 2022

Thanks for the PR! I'm not sure about the spans you've added to the README; I think that's a pretty good idea, but I'll wait for others' opinions on this.

@litetex
Copy link
Member

litetex commented Jan 16, 2022

Thanks for the PR! I'm not sure about the spans you've added to the README; I think that's a pretty good idea, but I'll wait for others' opinions on this.

I think those are for links which jump to the corresponding section of the document.


Note: ⚠️ This PR should be squash merged.

In my opinion it's also kind of hilarious that there is no French or German Readme - despite the fact that most of the dev-team speaks those languages

@litetex litetex merged commit f05affa into TeamNewPipe:dev Jan 21, 2022
@opusforlife2
Copy link
Collaborator

Thank you for the contribution!

This was referenced Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

localisation / translation Everything that has to do with translations or Weblate meta Related to the project but not strictly to code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants