[Feed] Save "Show watched items" toggle's status #7370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default sharedpreference is used to persist and retrieve show watched menu option toggle state
|
Unfortunately, nothing has changed in terms of behavior. |
litetex
requested changes
Nov 10, 2021
app/src/main/java/org/schabi/newpipe/local/feed/FeedViewModel.kt
Outdated
Show resolved
Hide resolved
litetex
approved these changes
Nov 11, 2021
There was a problem hiding this comment.
LGTM now.
I did some minor renaming and cleanup and fixed the problem from #7362 (comment) on the fly.
Ready for merging when no further problems occur.
opusforlife2
changed the title
This was referenced Nov 30, 2021
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default sharedpreference is used to persist and retrieve show watched menu option toggle state
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence