Skip to content

Conversation

triallax
Copy link
Contributor

What is it?

  • Feature (user facing)

Description of the changes in your PR

Add support for https://y2u.be links.

Fixes the following issue(s)

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@triallax triallax added the youtube Service, https://www.youtube.com/ label Oct 23, 2021
litetex
litetex previously approved these changes Oct 24, 2021
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Test okay: http://y2u.be/j4dMnAPZu70 could be opened

⚠️Ensure that the correct dependency (to TeamNewPipe) is used when merging

...as the required PR was merged.
litetex
litetex previously approved these changes Oct 26, 2021
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

litetex dismissed their stale review via 25e120b 40 seconds ago

Updated the extractor. Approval is unaffected and still valid.

But jitpack seems to have messed something up:
grafik

Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above...

Build seems to work when a shorter commit is used

@litetex litetex merged commit c673cb6 into TeamNewPipe:dev Nov 1, 2021
This was referenced Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

youtube Service, https://www.youtube.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

y2u.be support (Youtube URL shortener service)

2 participants