Skip to content

Fix check for new Version and release 0.21.12 #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Fix check for new Version and release 0.21.12 #7232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54d3bff
Move checking for new version to MainAcitvity
TobiGr Oct 12, 2021
7c9896b
Release NewPipe 0.21.12 (978)
TobiGr Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ android {
resValue "string", "app_name", "NewPipe"
minSdkVersion 19
targetSdkVersion 29
versionCode 977
versionName "0.21.11"
versionCode 978
versionName "0.21.12"

multiDexEnabled true

Expand Down
5 changes: 0 additions & 5 deletions app/src/main/java/org/schabi/newpipe/App.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@
import io.reactivex.rxjava3.functions.Consumer;
import io.reactivex.rxjava3.plugins.RxJavaPlugins;

import static org.schabi.newpipe.CheckForNewAppVersion.startNewVersionCheckService;

/*
* Copyright (C) Hans-Christoph Steiner 2016 <[email protected]>
* App.java is part of NewPipe.
Expand Down Expand Up @@ -113,9 +111,6 @@ public void onCreate() {
&& prefs.getBoolean(getString(R.string.show_image_indicators_key), false));

configureRxJavaErrorHandler();

// Check for new version
startNewVersionCheckService();
}

@Override
Expand Down
5 changes: 5 additions & 0 deletions app/src/main/java/org/schabi/newpipe/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@

package org.schabi.newpipe;

import static org.schabi.newpipe.CheckForNewAppVersion.startNewVersionCheckService;

import android.content.BroadcastReceiver;
import android.content.Context;
import android.content.Intent;
Expand Down Expand Up @@ -163,6 +165,9 @@ protected void onCreate(final Bundle savedInstanceState) {
FocusOverlayView.setupFocusObserver(this);
}
openMiniPlayerUponPlayerStarted();

// Check for new version
startNewVersionCheckService();
}

private void setupDrawer() throws Exception {
Expand Down
1 change: 1 addition & 0 deletions fastlane/metadata/android/en-US/changelogs/978.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed executing the check for a new NewPipe version. This check was executed too early sometimes and therefore lead to an app crash. That should be fixed now.