Skip to content

Conversation

litetex
Copy link
Member

@litetex litetex commented Oct 9, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Deduplicated drawer code in MainActivity.
Found out about this in #4104

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex litetex marked this pull request as ready for review October 9, 2021 14:40
@triallax triallax added the codequality Improvements to the codebase to improve the code quality label Oct 10, 2021
Copy link
Member

@Redirion Redirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@litetex litetex merged commit a2050a5 into TeamNewPipe:dev Oct 11, 2021
@litetex litetex deleted the code-cleanup-drawer-main-activity branch October 11, 2021 19:29
This was referenced Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codequality Improvements to the codebase to improve the code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants