Skip to content

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Sep 23, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Deleted unused drawables
  • Regenerated some drawables to their latest design

Icons with visible differences:

  • ic_next
  • ic_palette
  • ic_playlist_add
  • ic_playlist_add_check
  • ic_playlist_play
  • ic_previous
  • ic_search_add

Most of these are barely visible changes, but they ARE there. Only one is definitely noticeable, though (ic_playlist_play).

Before After
Screenshot_20210922-234704_NewPipe Screenshot_20210922-234731_NewPipe regenDrawables

If you want, you can create two tabs with "https://yqnn.github.io/svg-path-editor/" and copy-paste the old and new pathData in each tab respectively. That'll help you understand the changes more. (For drawables with multiple paths, simply copy-paste the first pathData, add a space, and then copy-paste the second pathData, etc.)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested the app "superficial" by checking the UI and didn't find any bigger problems

@AudricV AudricV added the codequality Improvements to the codebase to improve the code quality label Sep 24, 2021
@litetex litetex merged commit c1f7b26 into TeamNewPipe:dev Sep 25, 2021
@TacoTheDank TacoTheDank deleted the regenDrawables branch September 29, 2021 22:35
This was referenced Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codequality Improvements to the codebase to improve the code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants