Skip to content

Conversation

Aga-C
Copy link
Contributor

@Aga-C Aga-C commented Aug 21, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • added wrapping text to all SwitchPreferencesCompat

Before/After Screenshots/Screen Record

  • Before:
    image
  • After:
    image

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Aug 21, 2021
Copy link
Collaborator

@XiangRongLin XiangRongLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to all settings and not just switches. They could also have long titles depending on title

@XiangRongLin XiangRongLin added bug Issue is related to a bug and removed feature request Issue is related to a feature in the app labels Aug 21, 2021
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@TobiGr TobiGr merged commit e4dfce9 into TeamNewPipe:dev Aug 22, 2021
This was referenced Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug GUI Issue is related to the graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long titles in Settings don't wrap to the next line

4 participants