Skip to content

Conversation

@XiangRongLin
Copy link
Collaborator

@XiangRongLin XiangRongLin commented Jul 15, 2021

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

old Going with this https://exoplayer.dev/customization.html#customizing-server-interactions the `ResolvingDataSource.Resolver` should be called, but it isn't. I think it has something to do with exoplayer using different Extractors depending on the media type, see https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/source/ProgressiveMediaSource.html . But I once again have no clue why it's not calling my resolver since, MP4 is a Progressive media type, see https://exoplayer.dev/supported-formats.html#progressive-container-formats

Apply YoutubeThrottlingDecoder when fetching more of a video. This only solves streaming, not downloading

The code is shit and it most likely broke some other stuff, but for know i just want to know if this solves the throttling problem

Fixes the following issue(s)

Relies on the following changes

APK testing

app-debug.zip
/
app-debug.zip

Due diligence

@XiangRongLin XiangRongLin added bug Issue is related to a bug help wanted Help is wanted in fixing this issue youtube Service, https://www.youtube.com/ labels Jul 15, 2021
@XiangRongLin XiangRongLin added player Issues related to any player (main, popup and background) and removed help wanted Help is wanted in fixing this issue labels Jul 16, 2021
@njmdietrich
Copy link

Hey, so I installed this debug apk for testing, but have unfortunately now run into the buffering issue using it.
This time, the video played fine for a minute or so, which is different from how it usually works with the "main" app, where it occurs immediately upon playing a video. Again, I barely know what I am doing, but I have created another logcat here

@opusforlife2
Copy link
Collaborator

2021-07-17-yt-throttling.log

This is a log of the buffering issue starting, where I filtered the log using the word "newpipe". It's just one line repeating itself.

2021-07-17-yt-throttling-2.log

Same log, but this time filtered using the PID. Much more detailed.

@XiangRongLin
Copy link
Collaborator Author

Thanks for the logs. Luckily it was just a simple error on my part of replacing the wrong thing inside the url. I updated the debug apk at the top

@mvasl
Copy link

mvasl commented Jul 19, 2021

I can confirm that this PR fixes the issue for me.
POCO X3, Android 11.

@Thewisem

This comment has been minimized.

@XiangRongLin

This comment has been minimized.

@tsiflimagas
Copy link
Contributor

tsiflimagas commented Jul 20, 2021

It seems to have gotten more resistant to throttling, but not fixed for me. What's weird is that it seems to be getting fixed (most of the times) when switching to popup player, but buffering is throttled again when switching back to normal player.

newpipe_log.txt

@Thewisem

This comment has been minimized.

@Thewisem

This comment has been minimized.

@XiangRongLin

This comment has been minimized.

@Thewisem
Copy link

Try watching this video in 3x.
https://www.youtube.com/watch?v=oIKmsy4aTVw
Its not there in current newpipe. Only debug version

@XiangRongLin
Copy link
Collaborator Author

I updated the apk with the changes from the extractor. Functionality-wise nothing changed

@Thewisem
Copy link

It didn't fix the lag when 3x is done on that video

@njmdietrich
Copy link

I have run into the buffering issue using this version (though not the one with the changes from extractor, I hope that doesn't matter), although this time, instead of only playing for a second or two between buffering, it played for maybe 10 seconds at a time or so. But again, force closing the app was the only way to get it to play seamlessly.
I managed to record another log and filtered it. (hopefully correctly!)
The video in question

@opusforlife2
Copy link
Collaborator

So I've been using this PR for the whole of last week, and I have encountered the rapid buffering issue only a couple of times. But fortunately, it lasted for only 10 seconds or so, and then the buffer immediately expanded, loading 50 seconds ahead as expected.

@bibin-v2020
Copy link

bibin-v2020 commented Jul 25, 2021

The issue is not fixed completely in this apk but can see some improvements..

  • Buffering for some second's initially and then back to normal speed
  • Wipe Cache Data always fix the issue for me
  • Using Android 11 (Realme 3 Pro)

@infinitewaveparticle
Copy link

I used this apk successfully (no buffering) for 4 days, but today, after watching 2 videos, the issue has returned for every single video. I can no longer watch any videos above 360p and most I have to watch at 240p or 144p. I really want to use NewPipe. I love it. I appreciate all the hard work you put into it too. I will continue using it daily until this issue happens, and then I will use Vanced.

@XiangRongLin
Copy link
Collaborator Author

These changes are not needed anymore. Closing in favor of #6792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug player Issues related to any player (main, popup and background) youtube Service, https://www.youtube.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buffering video unrelated to connection

8 participants