-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Integrate YoutubeThrottlingDecoder into exoplayer #6673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey, so I installed this debug apk for testing, but have unfortunately now run into the buffering issue using it. |
|
This is a log of the buffering issue starting, where I filtered the log using the word "newpipe". It's just one line repeating itself. 2021-07-17-yt-throttling-2.log Same log, but this time filtered using the PID. Much more detailed. |
|
Thanks for the logs. Luckily it was just a simple error on my part of replacing the wrong thing inside the url. I updated the debug apk at the top |
|
I can confirm that this PR fixes the issue for me. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
It seems to have gotten more resistant to throttling, but not fixed for me. What's weird is that it seems to be getting fixed (most of the times) when switching to popup player, but buffering is throttled again when switching back to normal player. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Try watching this video in 3x. |
|
I updated the apk with the changes from the extractor. Functionality-wise nothing changed |
|
It didn't fix the lag when 3x is done on that video |
|
I have run into the buffering issue using this version (though not the one with the changes from extractor, I hope that doesn't matter), although this time, instead of only playing for a second or two between buffering, it played for maybe 10 seconds at a time or so. But again, force closing the app was the only way to get it to play seamlessly. |
|
So I've been using this PR for the whole of last week, and I have encountered the rapid buffering issue only a couple of times. But fortunately, it lasted for only 10 seconds or so, and then the buffer immediately expanded, loading 50 seconds ahead as expected. |
|
The issue is not fixed completely in this apk but can see some improvements..
|
|
I used this apk successfully (no buffering) for 4 days, but today, after watching 2 videos, the issue has returned for every single video. I can no longer watch any videos above 360p and most I have to watch at 240p or 144p. I really want to use NewPipe. I love it. I appreciate all the hard work you put into it too. I will continue using it daily until this issue happens, and then I will use Vanced. |
c86681e to
d9e95f0
Compare
|
These changes are not needed anymore. Closing in favor of #6792 |
What is it?
Description of the changes in your PR
old
Going with this https://exoplayer.dev/customization.html#customizing-server-interactions the `ResolvingDataSource.Resolver` should be called, but it isn't. I think it has something to do with exoplayer using different Extractors depending on the media type, see https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/source/ProgressiveMediaSource.html . But I once again have no clue why it's not calling my resolver since, MP4 is a Progressive media type, see https://exoplayer.dev/supported-formats.html#progressive-container-formatsApply
YoutubeThrottlingDecoderwhen fetching more of a video. This only solves streaming, not downloadingThe code is shit and it most likely broke some other stuff, but for know i just want to know if this solves the throttling problem
Fixes the following issue(s)
Relies on the following changes
APK testing
app-debug.zip/
app-debug.zip
Due diligence