Skip to content

Conversation

@fynngodau
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

For consistency and because streams should be able to link streams as well as playlists due to TeamNewPipe/NewPipeExtractor#593, this PR changes all references to "related streams" and replaces it with "related items".

Related NPE PR: TeamNewPipe/NewPipeExtractor#597

APK testing

Everything should work exactly like before in this apk:
app-debug.zip

Due diligence

@TobiGr
Copy link
Contributor

TobiGr commented Mar 31, 2021

Please also update the extractor version

@fynngodau
Copy link
Member Author

Right, forgot about that. Pipeline now passes.

@AudricV AudricV added feature request Issue is related to a feature in the app multiservice Issues related to multiple services labels Apr 1, 2021
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you! :-D I didn't test

@Stypox
Copy link
Member

Stypox commented Apr 2, 2021

Ok, I also tested and everything works well.

@Stypox Stypox merged commit 2af20d5 into TeamNewPipe:dev Apr 2, 2021
This was referenced Apr 11, 2021
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 23, 2021
@fynngodau fynngodau deleted the related-items branch May 2, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request Issue is related to a feature in the app multiservice Issues related to multiple services

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants