#5263: Allow the user to pause while a video is buffering

[Douile]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Allow the user to pause/unpause while a video is buffering
  • Check whether the playWhenReady is true instead of isPlaying: isPlaying returns false if the video is buffering

Fixes the following issue(s)

• fixes Can't pause video while buffering #5263

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

• I read the contribution guidelines.

[opusforlife2]

Yay! Much needed usability fix.

[Stypox]

Thank you!
Almost there ;-)

[Douile]

These changes seem to make
https://github.com/Douile/NewPipe/blob/963a7609f1681ec4942a2a3e560db82f280fc0e3/app/src/main/java/org/schabi/newpipe/player/Player.java#L709-L713

redundant, should I replace this snippit with playPause? I'm not sure why getPlayWhenReady was being used here but not in playPause

[Stypox]

@Douile nice catch. Replace every instance of if (getPlayWhenReady()) play(); else pause(); with playPause(), thanks

[Douile]

I think that's the only one.

[Stypox]

@Douile thank you :-D

[litetex]

ℹ This PR very likely caused #6179, see also #6179 (comment)