Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Feb 11, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@ghost ghost changed the title removed resizig text from popup player, as requested in #5514 removed resizig text from popup player Feb 11, 2021
@XiangRongLin
Copy link
Collaborator

Could you add before/after images?
I can't immediatly think of what is meant with "resizing text"

@ghost
Copy link
Author

ghost commented Feb 11, 2021

obraz
obraz

First one is before. Text "Resizing" is shown in top left corner while you resizing the pop-up window with two fingers.

@triallax triallax changed the title removed resizig text from popup player removed resizing text from popup player Feb 11, 2021
@XiangRongLin
Copy link
Collaborator

Thank you. After the current release is done, this can be merged.

@TobiGr TobiGr added the player Issues related to any player (main, popup and background) label Feb 15, 2021
@XiangRongLin XiangRongLin merged commit 5bc0a8f into TeamNewPipe:dev Feb 15, 2021
@alienthief
Copy link

@karkaminski thanks for making that ugly text go away

tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 21, 2021
…ent/remove_resizing_text

removed resizing text from popup player
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

player Issues related to any player (main, popup and background)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants