Skip to content

Fix the crash that occurs on navigating back to the main fragment. #5417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2021
Merged

Fix the crash that occurs on navigating back to the main fragment. #5417

merged 1 commit into from
Jan 15, 2021

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Jan 15, 2021 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Move setting the pager adapter and view binding to null to onDestroy from onDestroyView.

Fixes the following issue(s)

APK testing

debug.zip

Due diligence

@xibr xibr mentioned this pull request Jan 15, 2021
Merged
14 tasks
Stypox
Stypox approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so that's the issue. Thank you, and sorry for bothering ;-)

@Stypox Stypox merged commit 302fde6 into TeamNewPipe:dev Jan 15, 2021
@Isira-Seneviratne
Copy link
Member Author

Oh, so that's the issue. Thank you, and sorry for bothering ;-)

It's no problem :)

@Isira-Seneviratne Isira-Seneviratne deleted the Fix_crash_on_back_navigation branch January 15, 2021 07:57
This was referenced Jan 18, 2021
Closed
Merged
@Stypox Stypox mentioned this pull request Jan 21, 2021
Merged
5 tasks
@ghost ghost mentioned this pull request Apr 11, 2021
Open
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 20, 2021
@Stypox @tossj
Merge pull request TeamNewPipe/NewPipe#5417 from Isira-Seneviratne/Fi…
6f5cb62 
…x_crash_on_back_navigation

Fix the crash that occurs on navigating back to the main fragment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stypox Stypox Stypox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Isira-Seneviratne @Stypox