Skip to content

Conversation

AudricV
Copy link
Member

@AudricV AudricV commented Dec 20, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR changes NewPipe's website domain to the new domain in readmes.

Fixes the following issue(s)

#5109

Due diligence

@triallax
Copy link
Contributor

triallax commented Dec 20, 2020

There is still one place in the NewPipe codebase where newpipe.schabi.org is still used:

public static final String ERROR_EMAIL_ADDRESS = "[email protected]";

However, I'm not sure if changing it to newpipe.net is fine, so I'll ask whoever's in charge of infrastructure.

Edit: I asked about this, and apparently the e-mail address is still not changed, so we'll have to stick with [email protected] for now.

Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@TobiGr
Copy link
Contributor

TobiGr commented Dec 20, 2020

We did not change the email address yet.

@TobiGr TobiGr merged commit bf071d6 into TeamNewPipe:dev Dec 20, 2020
@AudricV AudricV deleted the change-domain-readme branch December 20, 2020 18:16
This was referenced Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants