Skip to content

Conversation

@Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Dec 19, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use ServiceCompat.stopForeground() so that the flags can be used on Android versions below Nougat.

APK testing

debug.zip

Due diligence

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I verified the call is equivalent and I tested; everything looks goof

@Stypox Stypox merged commit f590993 into TeamNewPipe:dev Dec 19, 2020
@Isira-Seneviratne Isira-Seneviratne deleted the Use_ServiceCompat_stopForeground branch December 19, 2020 23:02
This was referenced Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants