Skip to content

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Nov 30, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Clarify summary for export database.

Fixes the following issue(s)

APK testing

app-debug.apk.zip
app-debug.apk.zip
app-debug.apk.zip
app-debug.apk.zip

Due diligence

Stypox
Stypox previously approved these changes Nov 30, 2020
@Stypox
Copy link
Member

Stypox commented Dec 1, 2020

Remove the , before and

@Stypox Stypox merged commit 5f9e6b5 into TeamNewPipe:dev Dec 1, 2020
@Stypox
Copy link
Member

Stypox commented Dec 1, 2020

Looks good to me, thank you :-D

@triallax triallax deleted the improve-database-summaries branch December 1, 2020 19:49
@TobiGr
Copy link
Contributor

TobiGr commented Dec 1, 2020

I started the Weblate import. The changed strings should be translatable in a few minutes.

@TacoTheDank
Copy link
Member

Noooo, my beloved oxford commas! :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

export also saves settings

5 participants