Skip to content

Dispose of RxViews disposable in BaseStateFragment. #4944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2020
Merged

Dispose of RxViews disposable in BaseStateFragment. #4944

merged 1 commit into from
Nov 21, 2020

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Dispose of the Disposable created by RxView.clicks() in BaseStateFragment.

APK testing

debug.zip

Due diligence

Stypox
Stypox approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I tested some lists on network error and everything works as before. Thank you

@Stypox Stypox merged commit 1197f44 into TeamNewPipe:dev Nov 21, 2020
@Isira-Seneviratne Isira-Seneviratne deleted the Dispose_RxView_disposable branch November 21, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stypox Stypox Stypox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Isira-Seneviratne @Stypox