Skip to content

Conversation

opusforlife2
Copy link
Collaborator

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update list of Invidious URLs that work in the app.

Fixes the following issue(s)

  • New Invidious URLs don't work in Newpipe.

Relies on the following changes

Due diligence

@Stypox
Copy link
Member

Stypox commented Nov 17, 2020

Are you sure we should include all of them in the manifest? It will slow down the global share menu for the users installing NewPipe on their phones, and I guess many of those instances are not popular

@opusforlife2
Copy link
Collaborator Author

This is reducing the number of instances by two, so I'm sure it won't make it slower than it currently is, but probably a tiny bit faster.

@Stypox
Copy link
Member

Stypox commented Nov 17, 2020

Oh, then ok, this can be merged right after 0.20.3

@opusforlife2
Copy link
Collaborator Author

It will slow down the global share menu for the users

As for this, maybe once we're able to figure out how that PeerTube app is accepting share intents without putting URLs in the manifest, we could use that?

@Stypox
Copy link
Member

Stypox commented Nov 18, 2020

@opusforlife2 yes

@TobiGr TobiGr merged commit 5e95277 into dev Dec 12, 2020
@opusforlife2 opusforlife2 deleted the update_invidious_URLs branch December 12, 2020 12:11
This was referenced Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants