Skip to content

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Oct 22, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use TextViewCompat's setCompoundDrawablesRelativeWithIntrinsicBounds() method to support displaying drawables properly with RTL layouts on API level 17 and higher while allowing this change to be used in NewPipe Legacy.

APK testing

debug.zip

Due diligence

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thank you :-D

@Stypox Stypox merged commit a0ed803 into TeamNewPipe:dev Oct 25, 2020
@Isira-Seneviratne Isira-Seneviratne deleted the Use_TextViewCompat branch October 25, 2020 15:32
This was referenced Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants