Switch to the Java 8 Date/Time API. #4556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please make a separate PR for the multidex changes? I'm hoping it'll fix an issue with ACRA not finding classes in another dex. Edit: you also forgot to change NPE to your fork causing this PR to fail on CI |
Sure (although those changes were made because API desugaring requires multidex for all build types).
Thanks! |
Isira-Seneviratne
force-pushed
the
Switch_to_Java_8_Date_Time_API
branch
from
30c9649 to
c1cdb10
Compare
Isira-Seneviratne
force-pushed
the
Switch_to_Java_8_Date_Time_API
branch
2 times, most recently
from
c219aee to
a88b564
Compare
Isira-Seneviratne
force-pushed
the
Switch_to_Java_8_Date_Time_API
branch
6 times, most recently
from
5bb9e4f to
aa87082
Compare
Isira-Seneviratne
force-pushed
the
Switch_to_Java_8_Date_Time_API
branch
from
266f3ea to
f56cdf8
Compare
|
Closing and reopening to trigger a rebuild. |
Isira-Seneviratne
force-pushed
the
Switch_to_Java_8_Date_Time_API
branch
from
f56cdf8 to
742cad0
Compare
Isira-Seneviratne
force-pushed
the
Switch_to_Java_8_Date_Time_API
branch
3 times, most recently
from
b3ab770 to
414e421
Compare
Isira-Seneviratne
force-pushed
the
Switch_to_Java_8_Date_Time_API
branch
from
414e421 to
c745b84
Compare
Stypox
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Relies on the following changes
APK testing
debug.zip
Due diligence