Add button in settings to clear reCAPTCHA cookies

[wb9688]

What is it?

• Bug fix (user facing)
• Feature (user facing)
• Code base improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Add button in settings to clear reCAPTCHA cookies

Fixes the following issue(s)

Fixes #4279

Testing apk

app-debug.apk.zip

Agreement

• I carefully read the contribution guidelines and agree to them.

[TobiGr]

Code looks good to me. Did not test, but I guess, you did :)

[Stypox]

Code looks good to me, too, I don't see why it shouldn't work, though I will test.

@wb9688 could you provide an APK?

[Stypox]

Thank you. Shouldn't the preference be disabled or hidden when there are no cookies to clear?

[wb9688]

@Stypox: Now it's hidden when there's no cookie (and will hide when you press it). I confirmed that it works using Stetho.

[opusforlife2]

Does it always check for "no cookie" before hiding or does tapping it suffice? In other words, does it assume the operation will succeed or does it wait and check that cookies have been cleared before hiding? Is hiding prevented if the operation fails for whatever reason?

[Stypox]

Either the operation fails making the app crash before it gets to hide the button or the operation succeeds thus correctly hiding the button. So there is no room for inconsistency here

[Stypox]

Great, thank you!