Skip to content

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented Oct 7, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Don't show the Leaks launcher icon. Now there's a button in the debug settings to open it. Btw it was already possible to open it in new Android versions by long pressing NewPipe's launcher icon and then tapping on Leaks.

Agreement

@Stypox
Copy link
Member

Stypox commented Oct 7, 2020

Looks good to me, I assume you already checked everything works correctly. Thank you!

@Stypox Stypox merged commit 9e1bc63 into TeamNewPipe:dev Oct 7, 2020
@undeadfox
Copy link
Contributor

Release build fails:

app/src/main/java/org/schabi/newpipe/settings/DebugSettingsFragment.java:9: error: cannot find symbol
import leakcanary.LeakCanary;
                 ^

@wb9688
Copy link
Contributor Author

wb9688 commented Oct 8, 2020

@undeadfox: Oh, sorry, I'll fix that.

This was referenced Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants