Contributing guidelines reworked #4318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
reviewed
Sep 25, 2020
5 tasks
Co-authored-by: opusforlife2 <[email protected]>
Co-authored-by: opusforlife2 <[email protected]>
comradekingu
commented
Sep 26, 2020
Co-authored-by: opusforlife2 <[email protected]>
comradekingu
commented
Sep 26, 2020
Co-authored-by: opusforlife2 <[email protected]>
Co-authored-by: opusforlife2 <[email protected]>
Co-authored-by: opusforlife2 <[email protected]>
Co-authored-by: opusforlife2 <[email protected]>
B0pol
reviewed
Sep 26, 2020
Co-authored-by: bopol <[email protected]>
Co-authored-by: Tobias Groza <[email protected]>
Co-authored-by: Tobias Groza <[email protected]>
Comment on lines
+35
to
36
| * Do not bring non-free software (e.g. binary blobs) into the project. Make sure you do not introduce Google | ||
| libraries. |
There was a problem hiding this comment.
Suggested change
| * Do not bring non-free software (e.g. binary blobs) into the project. Make sure you do not introduce Google | |
| libraries. | |
| * Do not bring non-free software (e.g. binary blobs) into the project. Make sure you do not introduce Google libraries. |
Co-authored-by: opusforlife2 <[email protected]>
Co-authored-by: opusforlife2 <[email protected]>
Co-authored-by: opusforlife2 <[email protected]>
Co-authored-by: opusforlife2 <[email protected]>
Co-authored-by: opusforlife2 <[email protected]>
opusforlife2
requested changes
Oct 13, 2020
Co-authored-by: opusforlife2 <[email protected]>
TobiGr
approved these changes
Nov 28, 2020
|
thanks again! |
vkay94
pushed a commit
to vkay94/NewPipe
that referenced
this pull request
Nov 28, 2020
* Contributing guidelines reworked Co-authored-by: opusforlife2 <[email protected]> Co-authored-by: bopol <[email protected]> Co-authored-by: Tobias Groza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Readable text in the guidelines.
Fixes the following issue(s)
Testing apk
debug.zip
Agreement