Update Gradle and introduce Kotlin to NewPipe #2714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think, we do not need Kotlin in this project, aren`t? |
|
IMO Kotlin simplifies code a lot: easy null checks, less unnecessary brackets, etc. Apart from that, #2309 is written in Kotlin and I'd like to get this merged asap. |
|
I am in favour of the introduction of Kotlin, since it is faster to program in and the transition from Java is smooth |
TobiGr
previously approved these changes
Oct 31, 2019
TobiGr
force-pushed
the
introduce-kotlin
branch
from
05f9e62 to
137fabe
Compare
TobiGr
approved these changes
Nov 3, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Gradle and introduce Kotlin
I think it's time we introduce Kotlin to NewPipe as I consider it very nice to use. The main reasons/opinions as to why I think it'd be good to the project:
If you think this is not a good addition for NewPipe, please post your thoughts below.