Fix slow download speed #2486
Merged
Fix slow download speed #2486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix socket leak in "DownloadRunnable" * in "DownloadInitializer" close the HTTP body after doing range-request checks * in "DownloadRunnableFallback" fix typo in comment * in "DownloadDialog" fix regression, using one thread for audios instead of subtitles
|
Should this be added to 0.17.0? |
|
Yes, I was able to reporduce this on my devices. |
|
I am maybe wrong but is the first commit ("drop unused popup storage permission request") related to this merge request? |
|
@pihug12 no is unrelated, i just forget add to the pr summary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes socket leak in
DownloadRunnableDownloadInitializerclose the HTTP body after doing range-request checksDownloadDialogfix regression, using one thread for audios instead of subtitlesresolves Android Q Beta 5: Fails to access storage despite having permission #2470
if the speed change is not noticied, restart the device