Add move to next feature in play queue #2413
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I kinda like this idea. Queues are often done very poorly so if this gets added it's important to make sure the logic of manipulating the queue is consistent. It took PowerAmp like 5 years to finally get right. I highly recommend studying their queue behaviour in preparation for this feature. |
TobiGr
force-pushed
the
dev
branch
2 times, most recently
from
679bc75 to
2aeccc0
Compare
|
What's the state of this pr? Also there are no GitHub actions builds. |
litetex
added
the
waiting for author
|
@SameenAhnaf I will close it then 😄 |
SameenAhnaf
removed
the
waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make organizing songs within a PlayQueue easier, I have added a "move to next" menu item.
Feature added:
The move to next menu item appears when a PlayQueueItem is held down, bringing up the menu. The menu item will move this PlayQueueItem to the next-to-play position in the PlayQueue (that is, the index after the current playing song).
Why?
I use NewPipe often when commuting or at the gym and it's a wonderful application. One issue I've been running into, however, is organizing the play queue. Often I'll play a large public playlist with the intention of moving the songs I personally enjoy to the front. Furthermore, I'll also often enqueue songs not in the playlist to the queue. Currently this is a time-consuming task due to the time it takes to drag a song from the bottom to the top, not to mention bugs within the ItemTouchHelper that causes the drag to move way too fast after changing direction. By adding a menu option to move a PlayQueueItem to the next position in the PlayQueue, organizing songs can be more time efficient and less painful.