-
-
Couldn't load subscription status.
- Fork 3.3k
Try to recover pending download missions when possible #12550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to recover pending download missions when possible #12550
Conversation
|
Steps to follow for rigorously testing the fix under different conditions:
|
Does |
… gets killed Author: InfinityLoop1308 Adapted for NewPipe from a fork's this commit InfinityLoop1308/PipePipeClient-legacy@1cf059c
23793e3 to
9282cce
Compare
app/src/main/java/us/shandian/giga/service/DownloadManager.java
Outdated
Show resolved
Hide resolved
app/src/main/java/us/shandian/giga/service/DownloadManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this multiple times and did not run into new issues. Changes LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me as well.
What is it?
Description of the changes in your PR
This PR changes the app behavior where it considers ERROR_PROGRESS_LOST as invalid storage, however where it is possible to recover the pending download missions, it tries for that.
Fixes the following issue(s)
Fix app can't resume paused downloads in certain following situations:
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence