[YouTube] Support new kiosks and add migration to change trending kiosk tab #12450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
force-pushed
the
yt-trending-migration
branch
3 times, most recently
from
cb3711d to
2b6b8b7
Compare
ShareASmile
added
feature request
github-actions
bot
added
size/large
|
A command that can be used to test the migration: adb shell run-as org.schabi.newpipe.debug.pr12450 'sed -i '"'"'s#<int name="last_used_preferences_version" value="8" />#<int name="last_used_preferences_version" value="6" />#'"'"' shared_prefs/org.schabi.newpipe.debug.pr12450_preferences.xml' && adb shell run-as org.schabi.newpipe.debug.pr12450 'sed -i '"'"'s#\]}</string>#,{\"tab_id\":5,\"service_id\":0,\"kiosk_id\":\"Trending\"},{\"tab_id\":5,\"service_id\":1,\"kiosk_id\":\"Top 50\"}]}</string>#'"'"' shared_prefs/org.schabi.newpipe.debug.pr12450_preferences.xml' |
11 tasks
github-actions
bot
added
size/large
You can use this command to test instead:
adb shell run-as org.schabi.newpipe.debug.pr12450 'sed -i '"'"'s#<int name="last_used_preferences_version" value="8" />#<int name="last_used_preferences_version" value="6" />#'"'"' shared_prefs/org.schabi.newpipe.debug.pr12450_preferences.xml' && adb shell run-as org.schabi.newpipe.debug.pr12450 'sed -i '"'"'s#\]}</string>#,{\"tab_id\":5,\"service_id\":0,\"kiosk_id\":\"Trending\"},{\"tab_id\":5,\"service_id\":1,\"kiosk_id\":\"Top 50\"}]}</string>#'"'"' shared_prefs/org.schabi.newpipe.debug.pr12450_preferences.xml'
Currently translated at 12.7% (95 of 748 strings) Co-authored-by: fool <[email protected]>
Stypox
force-pushed
the
yt-trending-migration
branch
from
08b241f to
5aefa4a
Compare
Stypox
approved these changes
Jul 31, 2025
AudricV
changed the title
AudricV
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
To Do
Description of the changes in your PR
User-facing
Changes the combined YouTube Trending kiosk the the Live Trending kiosk. For more info see #12445.
Prevents / fixes crash for users which have the YT trending page as a separate kiosk.The kiosk has been kept, as it is still working for now.Dev-facing
Separates settings migrations from UI informing the user about the changes and the code that handles the UI prompts.
Allow queuing multiple user facing UI actions for SettingsMigrations.
Before/After Screenshots/Screen Record
Soon
Fixes the following issue(s)
Closes #1805, closes #12445
Relies on the following changes
Changes on the extractor side which have not yet been completed.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence