Skip to content

Feed group tab #12325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 4, 2025
Merged

Feed group tab #12325

merged 10 commits into from
Jun 4, 2025

Conversation

dev-victoria
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Add FeedGroups as optional Tabs. With this change you can use the settings of the main page content to add FeedGroups directly to the Main Page Tabs.

  • New Fragment used in the Settings to choose the FeedGroup
  • New TabClass FeedGroupTab
  • Added Code for Selecting the Tab
  • Added strings related to FeedGroupTab
  • Added FeedGroupTab to UnitTest

Before/After Screenshots/Screen Record

New possibility:
PR_AddingTabs_low.webm
PR_SavedTabs_low.webm

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@dev-victoria
Copied SelectFeedGroupFragment from SelectChannelFragment
86869f0
@dev-victoria
# Copied Layouts
e6c4690 
Copied select_channel_fragment to select_feed_group_fragment

Copied select_channel_item to select_feed_group_item

# Change
Replaced the Layout references in the new Class SelectFeedGroupFragment
@dev-victoria
# Change
7c3989f 
Adjusted the new Class SelectFeedGroupFragment for its Role
- Renamed Variables
- adjusted Imports
- adjusted Interface with FeedGroupEntity Values
@dev-victoria
# Change
436626f 
Adjusted select_feed_group_fragment Layout
 - reference select_feed_group_item layout
 - use new Strings

Added strings:
- select_a_feed_group
- no_feed_group_created_yet
@dev-victoria
# Change
f8ed8e5 
Added FEEDGROUP Tab Code to
 - ChooseTabsFragment
 - Tab

Added strings:
- feed_group_page_summary
@dev-victoria
# Change
279caac 
Layout select_feed_group_item (FeedGroup Picker in the Settings)
Remove rounded style from the icons
@dev-victoria
# Fixed Feed Group Titlebar
fd09e61 
- use default fragment_feed_title for TabName
- only clear FeedFragment bar subtitle when it matches the groupName to clear.
@dev-victoria
added FeedGroup to Tab Settings UnitTest
7127242
@dev-victoria
Use GroupName for the Settings Text.
205d18f 
The Tabname displays the default Feed title.
@github-actions github-actions bot added the size/large PRs with less than 750 changed lines label May 31, 2025
@Isira-Seneviratne
Copy link
Member

Thanks for the PR, but NewPipe is not currently accepting new features.

You could rebase this onto the refactor branch and target it there instead.

@Stypox
Copy link
Member

Stypox commented Jun 1, 2025

@Isira-Seneviratne you'd be right :-)
But we explicitly gave permission for this PR in the Matrix chat, since it is quite small, independent (i.e. doesn't change any architecture) and the user had already developed it for themselves

@dev-victoria
Copy link
Contributor Author

dev-victoria commented Jun 1, 2025 •
edited
Loading

Should I try to write generic Code for the Select[XY]Fragments used in the settings?

Stypox
Stypox approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, thank you! I tested it a bit on my phone and on an emulator, and everything seemed to work fine. I pushed a small commit that improves the items in the "Select a feed group" dialog, now the icons have the right size (24dp). Thanks again!

image

@Stypox Stypox enabled auto-merge June 4, 2025 09:20
@Stypox Stypox merged commit 8e036b5 into TeamNewPipe:dev Jun 4, 2025
5 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
6.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@AudricV AudricV added feature request Issue is related to a feature in the app feed Issue is related to the feed labels Jun 4, 2025
@Stypox Stypox mentioned this pull request Jul 17, 2025
Closed
11 tasks
whistlingwoods pushed a commit to whistlingwoods/FoxPipe that referenced this pull request Jul 27, 2025
@Stypox @whistlingwoods
Merge pull request TeamNewPipe#12325 from dev-victoria/FeedGroupTab
f1d4d0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stypox Stypox Stypox approved these changes

Assignees

No one assigned

Labels

feature request Issue is related to a feature in the app feed Issue is related to the feed size/large PRs with less than 750 changed lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow adding custom feeds as tabs

4 participants

@dev-victoria @Isira-Seneviratne @Stypox @AudricV