[YouTube] Access first element if array size is one #12150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression, where if the challenge data array size was one, the second element would be accessed, leading to a crash. This was introduced when porting the challenge parsing from JS to Kotlin. Ref: TeamNewPipe@53b599b
ShareASmile
added
bug
|
8 tasks
11 tasks
whistlingwoods
pushed a commit
to whistlingwoods/FoxPipe
that referenced
this pull request
Jul 27, 2025
[YouTube] Access first element if array size is one
10 tasks
whistlingwoods
pushed a commit
to whistlingwoods/FoxPipe
that referenced
this pull request
Oct 6, 2025
[YouTube] Access first element if array size is one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
If the challenge data array is of size one, the second element is accessed, leading to an
IndexOutOfBoundsException. I assume, that this is a typo, as the JS version did correctly access the first element.Fixes the following issue(s)
Due diligence