Skip to content

Conversation

malania02
Copy link
Contributor

@malania02 malania02 commented Mar 22, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This patch shows the download date for downloaded videos.

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Mar 22, 2025
@Stypox
Copy link
Member

Stypox commented Mar 22, 2025

Thanks! Could you add some screenshots, test on various devices, and test with failed downloads and other edge cases?

@malania02
Copy link
Contributor Author

This is how it looks: https://s1.directupload.eu/images/250327/q5cyqf3p.jpg
It is only visible once the download is finished because there isn't enough space to display it while the download progress is shown.

@ShareASmile ShareASmile added feature request Issue is related to a feature in the app downloader Issue is related to the downloader labels Mar 31, 2025
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For your information, you can upload screenshots directly to github, no need to use an external service ;-)

I just tested myself and unfortunately when holding the phone in landscape the text overlaps with the button, as seen below. Could you fix this and test all 4 combinations (grid + portrait, grid + landscape, list + portrait, list + landscape)? Thanks in advance!

Code looks good to me.

Screenshot_20250408-233737_NewPipe Debug

@malania02
Copy link
Contributor Author

Sorry, I copied the wrong constraint. Should be fixed now.

Copy link

sonarqubecloud bot commented Apr 9, 2025

@Stypox
Copy link
Member

Stypox commented Apr 9, 2025

Can you send screenshots in all 4 configurations for confirmation? Thanks in advance!

@malania02
Copy link
Contributor Author

Here are the screenshots:
portrait
landscape

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@Stypox Stypox merged commit 276bf39 into TeamNewPipe:dev Apr 11, 2025
7 checks passed
@Stypox Stypox mentioned this pull request Jul 17, 2025
11 tasks
whistlingwoods pushed a commit to whistlingwoods/FoxPipe that referenced this pull request Jul 27, 2025
Show download date of downloaded videos
whistlingwoods pushed a commit to whistlingwoods/FoxPipe that referenced this pull request Oct 6, 2025
Show download date of downloaded videos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

downloader Issue is related to the downloader feature request Issue is related to a feature in the app size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants