-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Show download date of downloaded videos #12117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! Could you add some screenshots, test on various devices, and test with failed downloads and other edge cases? |
This is how it looks: https://s1.directupload.eu/images/250327/q5cyqf3p.jpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! For your information, you can upload screenshots directly to github, no need to use an external service ;-)
I just tested myself and unfortunately when holding the phone in landscape the text overlaps with the button, as seen below. Could you fix this and test all 4 combinations (grid + portrait, grid + landscape, list + portrait, list + landscape)? Thanks in advance!
Code looks good to me.
Sorry, I copied the wrong constraint. Should be fixed now. |
|
Can you send screenshots in all 4 configurations for confirmation? Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!
Show download date of downloaded videos
Show download date of downloaded videos
What is it?
Description of the changes in your PR
This patch shows the download date for downloaded videos.