Skip to content

Conversation

mileskrell
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Include full locale info in audio track labels

Before/After Screenshots/Screen Record

Before After
before after

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Mar 11, 2025
Copy link

@Stypox
Copy link
Member

Stypox commented Mar 11, 2025

Have you tested this in languages other than English, to see if everything is translated correctly?

@mileskrell
Copy link
Contributor Author

@Stypox yep - here's Spanish:

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Stypox Stypox merged commit 3047704 into TeamNewPipe:dev Mar 15, 2025
8 checks passed
@ShareASmile ShareASmile added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels Mar 15, 2025
@Stypox Stypox mentioned this pull request Jul 17, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug player Issues related to any player (main, popup and background) size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audio track display names don't specify region/country

4 participants