Skip to content

Conversation

FineFindus
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

YouTube has started to mix members-only videos into the normal videos in the Videos tab. This filters them, as they cannot be watched without an account, leading to clutter in the feed.

Before/After Screenshots/Screen Record

Before After
Feed with members-only videos Feed without members-only videos

Fixes the following issue(s)

Closes: #12011
Closes: #12040

Relies on the following changes

TeamNewPipe/NewPipeExtractor#1280.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

YouTube has started to mix members-only videos into the normal videos in
the Videos tab. This filters them, as they cannot be watched without an
account, leading to clutter in the feed.
Requires TeamNewPipe/NewPipeExtractor#1280.

Closes: TeamNewPipe#12011
Closes: TeamNewPipe#12040
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Mar 2, 2025
@ShareASmile ShareASmile added feature request Issue is related to a feature in the app youtube Service, https://www.youtube.com/ feed Issue is related to the feed labels Mar 2, 2025
@eternal-sorrow
Copy link

Is this optional? If not, this shouldn't be merged. The video could still be watched in a browser (possibly on another device).

@Profpatsch
Copy link
Contributor

It’s probably better to display some kind of greyed-out version that cannot be clicked as long as we are not able to extract info for the member-only videos, but still list them in the stream (so they can be opened in the browser).

Since the upstream change to the extractor is not in yet, I’d close this for now, but thanks for the contribution!

@Profpatsch Profpatsch closed this May 9, 2025
@FineFindus FineFindus deleted the fix/filter-membership-videos branch May 9, 2025 20:36
@Stypox
Copy link
Member

Stypox commented May 10, 2025

Why not just adding a checkbox in the "Show/Hide streams" menu? We have already a checkbox there for "Upcoming", so it would make sense to add another one for "Members-only" (enabled by default)

@FineFindus
Copy link
Contributor Author

I'm strongly against adding preferences, so if that's the preferred solution, I won't continue to work on it.

@Stypox
Copy link
Member

Stypox commented May 10, 2025

I agree with you on not adding preferences, but I think a checkbox in the Show/Hide Streams menu is more easily discoverable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request Issue is related to a feature in the app feed Issue is related to the feed size/small PRs with less than 50 changed lines youtube Service, https://www.youtube.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[YouTube] Make members-only videos in subscription list recognisable Being able to open the members-only video page

5 participants