Skip to content

Conversation

@tfga
Copy link
Contributor

@tfga tfga commented Feb 25, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Before/After Screenshots/Screen Record

TODO

  • Before:
  • After:

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/large PRs with less than 750 changed lines label Feb 25, 2025
wb9688
wb9688 previously requested changes Feb 25, 2025
It's no longer needed after the conversion to Kotlin.
@tfga tfga requested review from Stypox and wb9688 March 12, 2025 22:45
tfga added 2 commits March 13, 2025 19:10
    <string name="share_playlist_with_titles_message">Share playlist with details such as playlist name and video titles or as a simple list of video URLs</string>
    Share playlist with details such as playlist name and video titles or as a simple list of video URLs</string>

(Discussion: TeamNewPipe#12065 (comment))
@tfga tfga marked this pull request as ready for review March 15, 2025 01:16
@tfga tfga requested a review from Stypox March 15, 2025 01:23
@sonarqubecloud
Copy link

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me

@Stypox Stypox merged commit 3dcfdaf into TeamNewPipe:dev Mar 15, 2025
7 checks passed
@ShareASmile ShareASmile added feature request Issue is related to a feature in the app youtube Service, https://www.youtube.com/ playlist Anything to do with playlists in the app labels Mar 15, 2025
@Stypox Stypox mentioned this pull request Jul 17, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request Issue is related to a feature in the app playlist Anything to do with playlists in the app size/large PRs with less than 750 changed lines youtube Service, https://www.youtube.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share playlist as YouTube temporary playlist

4 participants