Skip to content

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Feb 16, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

The logs related to animations are almost never useful, but they add a lot of noise to logcat. This PR hides those logs by default, though they can still be enabled by manually setting DEBUG = MainActivity.DEBUG (instead of false) in the View.kt file.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@Stypox Stypox added the codequality Improvements to the codebase to improve the code quality label Feb 16, 2025
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Feb 16, 2025
@TobiGr TobiGr merged commit fb4a65a into dev Mar 15, 2025
5 of 6 checks passed
@TobiGr TobiGr deleted the hide-view-logs branch March 15, 2025 16:18
@Stypox Stypox mentioned this pull request Jul 17, 2025
11 tasks
whistlingwoods pushed a commit to whistlingwoods/FoxPipe that referenced this pull request Jul 27, 2025
Disable logs about view animations by default
whistlingwoods pushed a commit to whistlingwoods/FoxPipe that referenced this pull request Oct 6, 2025
Disable logs about view animations by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codequality Improvements to the codebase to improve the code quality size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants